-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
### Changes - [x] Added logo to the top - [x] Aligned header elements to the center > This change will make it look symmetrical and in a proper format.
Can you share a screenshot? |
Sure @mrkev , Summary updated! We do have other options to look for i.e., we can place the gif after the introductory content. I would like to know your thoughts on this. Thanks 👍 |
@iamdarshshah I think keeping the gif there is ok— it's a quick way of seeing what draft is and we should open with it. The logo looks a little big though. I know it's a current design trend to have the big, centered logo, but this always felt weird. I did a little research and I think it's probably because other Facebook JS projects don't even show their logo on their readme: react-native, react, relay. It's a cool logo though, so I'm down to try it out. Can we try putting it inline before the title (ie, "[logo] Draft.js")? That'd be my first option, though I'm open to see how it looks on top but maybe like around 50% smaller (: |
Okay, agreed! @mrkev 👍
Already did that, but the text was not aligning center vertically. Also, that was not looking as we are expecting it to look. Thus, my suggestion for this is to create an SVG that includes Regarding reducing image size by 50%, then it will look like this: |
Actually, 50% size looks good. No need to go about doing the SVG "[logo] text" IMO. Let me know when the commit is updated and I'll import it (: |
Thanks @mrkev 👍 , commit is Updated. You can now review it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: **Summary** #### Changes - [x] Added logo to the top - [x] Aligned header elements to the center > This change will make it look symmetrical and aligned in a proper format. > Screenshot ![Draft JS](https://user-images.githubusercontent.com/25670841/88580007-9993d500-d068-11ea-879c-b84c4944b989.png) Pull Request resolved: facebookarchive/draft-js#2523 Reviewed By: elboman Differential Revision: D22785917 Pulled By: mrkev fbshipit-source-id: 06fe02430aadea761f30adb6a01218b732d818af
Summary
Changes